Opened 2 years ago

Closed 8 months ago

#277 closed defect (fixed)

misleading option in config.w32

Reported by: tk1 Owned by: moo
Priority: trivial Milestone: 3.1.0
Component: build Version: 1.3.2
Keywords: config.w32 windows compiling Cc:
Application: PHP Version: 5.3 & 5.4
Other Exts: SAPI: Irrelevant
Probability: Always Blocked By:
Blocking:

Description

Line:

ARG_ENABLE("xcache", "Include XCache support", "yes,shared");

in the config.w32 file is misleading. It leads to the message

 --disable-xcache                            Include XCache support

as a result of command

C:\php>configure --help

of the "stepbystepbuild" (compiling under windows).

When I changed:

ARG_ENABLE("xcache", "Include XCache support", "yes,shared");

to:

ARG_ENABLE("xcache", "Include XCache support", "no");

Then correct message was shown:

--enable-xcache                             Include XCache support

.

Change History (5)

comment:1 Changed 2 years ago by moo

  • pending changed from 0 to 1

xcache is default to be built as shared module (dll) under win32 build system. isn't this correct? even if you omit --enable-xcache it shall build xcache

comment:2 Changed 2 years ago by tk1

Currently "configure --help" message shown says: disable xcache to be enabled. Which is not clear.

If you change "yes,shared" to "no" then correct message and parameter will be shown.

Parameter

C:\PHP\>configure --enable-xcache=shared,option

will give the same result (dll).

Additionaly, compiling xcache for windows will be similar to compiling on unixes ( config.m4 & http://xcache.lighttpd.net/wiki/InstallFromSource).

comment:3 follow-up: Changed 2 years ago by moo

you're right about the message. i'll think twice before making the decision

btw. --enable-xcache is not needed when building xcache alone using phpize && ./configure under unixes, php guys have done the trick

comment:4 in reply to: ↑ 3 Changed 8 months ago by tk1

Replying to moo:

you're right about the message. i'll think twice before making the decision

btw. --enable-xcache is not needed when building xcache alone using phpize && ./configure under unixes, php guys have done the trick

I understand. My suggestion applies only to Windowses. Anyone who read (https://wiki.php.net/internals/windows/stepbystepbuild) and compiles PHP and extensions must now how to enable/disable extensions. I only suggest to adjust xcache to PHP windows standard.

comment:5 Changed 8 months ago by moo

  • Milestone changed from undecided to 3.1.0
  • Probability set to Always
  • Resolution set to fixed
  • Status changed from new to closed

fixed in [1345]. Let's do it like apc/ea way

Note: See TracTickets for help on using tickets.