Opened 6 years ago

Closed 6 years ago

#211 closed defect (fixed)

m4 macros should be quoted

Reported by: rcasagraude Owned by: moo
Priority: minor Milestone: 1.3.0
Component: build Version: 1.2.2
Keywords: m4 macro Cc:
Application: PHP Version:
Other Exts: SAPI: Irrelevant
Probability: Sometimes Blocked By:
Blocking:

Description

Just a little patch to prevent recursion in macro definition.
That made me crazy for some time trying to build xcache in a mock dir called builddir - a default in fedora for example…

diff -up xcache-1.2.2/Makefile.frag.orig xcache-1.2.2/Makefile.frag
--- xcache-1.2.2/Makefile.frag.orig	2007-12-28 17:00:00.000000000 +0100
+++ xcache-1.2.2/Makefile.frag	2009-02-14 00:50:21.000000000 +0100
@@ -14,7 +14,7 @@ $(XCACHE_STRUCTINFO_OUT): $(XCACHE_INCLU
	-$(XCACHE_AWK) -f $(srcdir)/mkstructinfo.awk < $(XCACHE_INCLUDES_I) > $(XCACHE_STRUCTINFO_OUT).tmp && mv -f $(XCACHE_STRUCTINFO_OUT).tmp $(XCACHE_STRUCTINFO_OUT)

$(XCACHE_PROC_OUT): $(XCACHE_PROC_SRC) $(XCACHE_STRUCTINFO_OUT) $(XCACHE_PROC_SOURCES)
-	$(M4) -D srcdir="$(srcdir)" -D builddir="$(builddir)" $(XCACHE_ENABLE_TEST) $(XCACHE_PROC_SRC) > $(XCACHE_PROC_OUT).tmp
+	$(M4) -D srcdir='`'"$(srcdir)'" -D builddir='`'"$(builddir)'" $(XCACHE_ENABLE_TEST) $(XCACHE_PROC_SRC) > $(XCACHE_PROC_OUT).tmp
	mv -f $(XCACHE_PROC_OUT).tmp $(XCACHE_PROC_OUT)

$(XCACHE_PROC_H): $(XCACHE_PROC_OUT)

Change History (2)

comment:1 Changed 6 years ago by moo

  • Status changed from new to accepted

comment:2 Changed 6 years ago by moo

  • Resolution set to fixed
  • Status changed from accepted to closed

fixed in [585] for trunk

Note: See TracTickets for help on using tickets.