xcache with streams on ZEND_ENGINE_2

[lang@…]

Hi xcache developers,
this patch permits to process streams from xcache on ZEND_ENGINE_2. It is very helpfully when a php module use streams.

xcache-1.2.

@@ -727 +727 @@
        php = xce->data.php;
 
        if (XG(stat)) {
+
+#ifdef ZEND_ENGINE_2
+               php_stream_statbuf ssb;
+               php_stream_wrapper *wrapper = NULL;
+               char *path_for_open = NULL;
+
+               wrapper = php_stream_locate_url_wrapper(filename, &path_for_open, 0 TSRMLS_CC);
+               if ((wrapper) && (wrapper->wops) && (wrapper->wops->url_stat) &&
+                   (wrapper != &php_plain_files_wrapper) &&
+                   (SUCCESS == wrapper->wops->url_stat(wrapper, path_for_open, PHP_STREAM_URL_STAT_QUIET, &ssb, NULL TSRMLS_CC))) {
+                       pbuf = &ssb.sb;
+                       goto stat_done;
+               }
+#endif
+
                if (strcmp(SG(request_info).path_translated, filename) == 0) {
                        /* sapi has already done this stat() for us */
                        pbuf = sapi_get_stat(TSRMLS_C);

[judas_iscariote]

This patch looks fine, moo what you think ?

[hlang]

Hi xcache developers, this is the new patch of the xcache version 1.3.0 for the feature to cache streams by xcache.
I think still always this is very helpfully.

xcache-1.3.

@@ -800 +800 @@
         return FAILURE;
     }
 
+    /*
     if (strstr(filename, "://") != NULL) {
         return FAILURE;
     }
+    */
 
     php = xce->data.php;
 
     if (XG(stat)) {
+
+#ifdef ZEND_ENGINE_2
+        php_stream_statbuf ssb;
+        php_stream_wrapper *wrapper = NULL;
+        char *path_for_open = NULL;
+
+        wrapper = php_stream_locate_url_wrapper(filename, &path_for_open, 0 TSRMLS_CC);
+        if ((wrapper) && (wrapper->wops) && (wrapper->wops->url_stat) &&
+            (wrapper != &php_plain_files_wrapper) && 
+            (SUCCESS == wrapper->wops->url_stat(wrapper, path_for_open, PHP_STREAM_URL_STAT_QUIET, &ssb, NULL TSRMLS_CC))) {
+            pbuf = &ssb.sb;
+            goto stat_done;
+        }
+#endif
+
         if (strcmp(SG(request_info).path_translated, filename) == 0) {
             /* sapi has already done this stat() for us */
             pbuf = sapi_get_stat(TSRMLS_C);

[moo]

already in 2.0. reopen bug if there's problem with streams

[hlang]

patch cache php modul streams in xcache version 2.0.x

[hlang]

patch cache php modul streams in xcache version 1.3.x

[hlang]

patch cache php modul streams in xcache version 1.2.x

[hlang]

hello,

php modul streams does always not work with xcache.
the function xc_compile_file() excludes the posibility.
xcache could also accelerate php modul streams.

i attached the patch to cache php modul streams in xcache version 2.0.x

[moo]

please also provide your test case

[hlang]

the test case is attached as phpmodulstream.tgz

# to create phpmodulstream.so
phpize
./configure
make

# find the php modul phpmodulstream.so in subdir modules

# add the phpmodulstream.so to your php configuration
# in extension path
extension=phpmodulstream.so
# or absolute path
extension=/<your>/<current>/<make>/<path>/modules/phpmodulstream.so

# restart apache

# correct installation shows part phpmodulstream in phpinfo()

# move test.php to htdocs and call it from browser
# access for stream is phpmodulstream://whatever...
# example
require_once 'phpmodulstream://blafasel.php';

# xcache work correct when reload from test.php shown always same time

[hlang]

patch cache php modul streams in xcache version 3.0.0

[hlang]

modul code for test case phpmodulstream

[hlang]

i attach the patch for xcache-trunc

[moo]

thanks. The logic of that part in XCache need to be rechecked for both optimize and feature

[moo]

the patch is rewrite carefully, committed as [1140] for trunk (3.0.0-dev). please try it out

i thought the test case was simply *.php code. i wonder if user defined stream protocol can be include()'d and cached correctly. i'd like there be some *.phpt code for this under xcache/tests/

thanks for your time making patch. but XCache dev has stopped adding features to 2.0.x 1.3.x 1.2.x. not new release for 1.3.x 1.2.x critical security problem

[hlang]

i'm so happy.
i test your commit and it run perfect.
we use this stream access over 10 years and only xcache can cache streams really stable.

thank you for that implemention.