Changeset 1187 for trunk/mod_cacher/xc_cacher.c

Timestamp:

12/07/2012 10:25:21 AM (6 months ago)

Author:

moo

Message:

fix magic number: use 0 1 with zend_bool only. use FAILURE for int return type to avoid confusing. fix usage of 0

Files:

• trunk/mod_cacher/xc_cacher.c (modified) (7 diffs)

trunk/mod_cacher/xc_cacher.c

@@ -224 +224 @@
 /* }}} */
 
-static inline int xc_entry_equal_unlocked(xc_entry_type_t type, const xc_entry_t *entry1, const xc_entry_t *entry2 TSRMLS_DC) /* {{{ */
+static inline zend_bool xc_entry_equal_unlocked(xc_entry_type_t type, const xc_entry_t *entry1, const xc_entry_t *entry2 TSRMLS_DC) /* {{{ */
 {
     /* this function isn't required but can be in unlocked */
@@ -2204 +2204 @@
 
 /* gdb helper functions, but N/A for coredump */
-int xc_is_rw(const void *p) /* {{{ */
+zend_bool xc_is_rw(const void *p) /* {{{ */
 {
     xc_shm_t *shm;
@@ -2229 +2229 @@
 }
 /* }}} */
-int xc_is_ro(const void *p) /* {{{ */
+zend_bool xc_is_ro(const void *p) /* {{{ */
 {
     xc_shm_t *shm;
@@ -2560 +2560 @@
     }
 
-static inline int xc_var_has_prefix(xc_entry_t *entry, zval *prefix TSRMLS_DC) /* {{{ */
+static inline zend_bool xc_var_has_prefix(xc_entry_t *entry, zval *prefix TSRMLS_DC) /* {{{ */
 {
     zend_bool result = 0;
@@ -2593 +2593 @@
     zend_register_long_constant(ZEND_STRS("XC_TYPE_PHP"), XC_TYPE_PHP, CONST_CS | CONST_PERSISTENT, module_number TSRMLS_CC);
     zend_register_long_constant(ZEND_STRS("XC_TYPE_VAR"), XC_TYPE_VAR, CONST_CS | CONST_PERSISTENT, module_number TSRMLS_CC);
-    return 0;
+    return SUCCESS;
 }
 /* }}} */
@@ -2737 +2737 @@
         shm = NULL;
     }
-    return 0;
+    return FAILURE;
 }
 /* }}} */
@@ -2809 +2809 @@
 
 /* user functions */
-static int xcache_admin_auth_check(TSRMLS_D) /* {{{ */
+static zend_bool xcache_admin_auth_check(TSRMLS_D) /* {{{ */
 {
     zval **server = NULL;